Why does the shiny star appear on all my Pokémon even if they're not shiny?

Question

That's all, the title says everything.

My summary top script based on the new one. (Will clean unnecesary parts later)

Answer 1

Avoid redifining the whole script just to change few things, it makes it harder to port over updates ^^'

Otherwise, can you check that your game isn't actually treating all pokemon as shiny?
Try $actors[0].shiny? in the console to check what it does say.

It is possible that your shiny_rate is very high or your pokemon are all generated as shiny, the console will tell us :) (Your code looks correct).

Comments

Hi! I will check that of not redefining later. I tried the command, but I get nothing but an empty line.

---

Weird, it should show either true, false or an error.

Was there a save loaded when you did?

---

Yes, it happens on all of the saves I tried, but I tried creating a new game and still happens. I have to say it didn't happen before, so I'm extremely confused.

---

Do you have a script change of PFM::Pokemon ?

Otherwise, can you do: $actors[0].inspect in the console and send me the huuuuuuuge amount of text it will print. I might be able to guess some stuff from that ^^

---

About pfm pokémon, I don't remember editing anything on that.

About the huge text, here it is. Sorry for taking so long just for this thing
#<PFM::Pokemon:0x0fdf2498 @id=940, @code=592047224, @level=50, @step_remaining=0, @ribbons=[], @skill_learnt=[:gunk_shot, :earthquake, :leech_life, :sandstorm, :sunny_day], @skills_set=[#<PFM::Skill:0x0fdf2300 @id=241, @ppmax=5, @pp=5, @db_symbol=:sunny_day>, #<PFM::Skill:0x0fdf22a0 @id=141, @ppmax=10, @pp=10, @db_symbol=:leech_life>, #<PFM::Skill:0x0fdf2288 @id=89, @ppmax=10, @pp=10, @db_symbol=:earthquake>, #<PFM::Skill:0x0fdf2270 @id=441, @ppmax=5, @pp=5, @db_symbol=:gunk_shot>], @sub_id=nil, @sub_code=nil, @sub_form=nil, @status=0, @status_count=0, @battle_stage=[0, 0, 0, 0, 0, 0, 0], @position=0, @battle_turns=0, @mega_evolved=false, @captured_with=4, @captured_at=1660033451, @captured_level=50, @egg_in=nil, @egg_at=nil, @trainer_id=254369417, @trainer_name="Tetabester", @captured_in=15729017, @given_name=nil, @memo_text=nil, @gender=1, @character=nil, @form=0, @exp=142500, @exp_rate=0.0, @loyalty=70, @rareness=nil, @ev_hp=0, @ev_atk=0, @ev_dfe=0, @ev_spd=0, @ev_ats=0, @ev_dfs=0, @iv_hp=4, @iv_atk=9, @iv_dfe=17, @iv_spd=5, @iv_ats=7, @iv_dfs=7, @nature=8, @hp=122, @hp_rate=1, @item_holding=0, @ability=:extreme_shield, @ability_used=false, @ability_index=0, @db_symbol=:duracran>

---

Ok the Pokemon is definitively not shiny.

I found out the issue.
data= is define twice. The first time it's setting @star.visible to pokemon.shiny. The second time it's not and when you define function twice, the last defined function overwrite completely the first one :)
Just copy line 21 between line 66 and 67

---

Hahahaha I can't belive I didn't notice that. It works now. Thanks again!